I've been trying to do more Circle reviews lately, and I've noticed that a lot of apps have very similar papercuts. Some of the classics are:
- Not using the standard keyboard shortcuts (e.g. Ctrl+, for opening preferences) https://developer.gnome.org/hig/reference/keyboard.html
- Missing a11y labels on buttons
- Longer blocks of text not being screen reader accessible
- Focus borders being weirdly shaped/glitchy
Maybe having a little checklist for app devs to do themselves before applying could catch some of these?
@tbernard I've been thinking of writing a piece on applying to Circle, that would also include tips about looking through the entire review checklist before applying, being somewhat responsive to the reviewers during the process, etc. Some common papercuts could totally be included in that.
@bragefuglseth Do it, that's a great idea! Happy to look over drafts :)
That said, I was thinking maybe we could also just include a few of these things in the actual issue template for applying?
@tbernard @bragefuglseth Yes, do it! Great stuff! Ofc there must be room for joining and improving over time, but if there are a11y stuff like this which is easy to fix but often forgotten/overlooked, it should be included in the requirements to get accepted
@forteller Circle does already have pretty clear a11y requirements, the problem is that we find issues related to these that the app developers could have discovered themselves with some quick testing.
You can read the full list here: https://gitlab.gnome.org/Teams/Releng/AppOrganization/-/blob/main/AppCriteria.md