I've just released #ncdu 1.14. This release adds mtime display & sorting, a limited form of --follow-symlinks, can display larger file counts in the file browser and fixes a few bugs you weren't likely to trigger anyway.

Get it from
dev.yorhel.nl/ncdu

Follow

@ayo I like the mtime stuff! πŸ˜‰ Thanks for the feedback on my patches.

@blunaxela Ooh I hadn't realized you were on Mastodon! Good work on the mtime patches, most people give up after my first round of feedback. πŸ˜…

@ayo Yeah, I saw your mastodon handle on your webpage and was tempted to send patches on here instead! 😝 BTW, I have a silly change set that makes dir_scan.c pthreaded. Still pretty slow... It's maybe 2x faster for NFS, but other cases are much slower. I'll let you know if I make any real progress.

@blunaxela So you weren't kidding about that threading!

Now I'm curious about your approach. The dir_output interface doesn't allow for much parallelism; Probably the only thing that can be "easily" done in parallel are the stat() calls for all files in a single directory, but I'd imagine quite a high synchronization overhead for that in many cases.

@ayo
My approach has been to start a thread for each dir up to N threads. I had remove a number of global variables and pass the current dir context in order to make dir_walk and recur reentrant. It also fstats by full path since chdir isn't thread friendly. The most expensive part right now is mallocs and it's threading on every item, instead of just dirs. There's a lock on item() to protect the tree and addstatstoparents()

@ayo
Oh, I just realized that there could be a lock on item() for each independent branch of the tree as well! That might be interesting to coordinate.

@blunaxela Scanning multiple dirs in parallel doesn't seem like it'll work well with the ordering that item() expects. File export, in particular, is going to be hard to fix, I think.

Extra consideration with passing full paths to syscalls: Make sure to test nested dirs exceeding PATH_MAX.

@ayo
I pass the the current dir struct around via argument and don't use globals in item() and item_add() other than the absolute root for the whole tree. So far it works with -0 output. Yeah... export would have to be redone to use the struct tree after it's done.

@ayo
As for PATH_MAX, I want to switch to fstatat(). Then there's less checking for fated as well. Although I'm starting to wonder what's POSIX and what's Linux.

@blunaxela The point of export is that it doesn't need much memory...

I think the best approach is keeping the threading inside dir_scan.c and serialize/ coordinate calls to item() to ensure correct ordering. This complicates and limits the task distribution a bit, but it keeps the complexity from affecting other parts.

Sign in to participate in the conversation
Fosstodon

Fosstodon is a Mastodon instance that is open to anyone who is interested in technology; particularly free & open source software.